refactor: remove unused role

src/controllers/customer-branch-controller.ts

@@ -24,15 +24,7 @@ if (!process.env.MINIO_BUCKET) {
 }
 
 const MINIO_BUCKET = process.env.MINIO_BUCKET;
-const MANAGE_ROLES = [
+const MANAGE_ROLES = ["system", "head_of_admin", "admin", "branch_manager", "head_of_sale", "sale"];
-  "system",
-  "head_of_admin",
-  "admin",
-  "branch_admin",
-  "branch_manager",
-  "head_of_sale",
-  "sale",
-];
 
 function imageLocation(id: string) {
   return `employee/profile-img-${id}`;

src/controllers/customer-controller.ts

@@ -24,15 +24,7 @@ if (!process.env.MINIO_BUCKET) {
 }
 
 const MINIO_BUCKET = process.env.MINIO_BUCKET;
-const MANAGE_ROLES = [
+const MANAGE_ROLES = ["system", "head_of_admin", "admin", "branch_manager", "head_of_sale", "sale"];
-  "system",
-  "head_of_admin",
-  "admin",
-  "branch_admin",
-  "branch_manager",
-  "head_of_sale",
-  "sale",
-];
 
 export type CustomerCreate = {
   registeredBranchId?: string;

src/controllers/employee-checkup-controller.ts

@@ -16,15 +16,7 @@ import prisma from "../db";
 import HttpStatus from "../interfaces/http-status";
 import HttpError from "../interfaces/http-error";
 
-const MANAGE_ROLES = [
+const MANAGE_ROLES = ["system", "head_of_admin", "admin", "branch_manager", "head_of_sale", "sale"];
-  "system",
-  "head_of_admin",
-  "admin",
-  "branch_admin",
-  "branch_manager",
-  "head_of_sale",
-  "sale",
-];
 
 type EmployeeCheckupPayload = {
   checkupType?: string | null;

src/controllers/employee-controller.ts

@@ -24,15 +24,7 @@ if (!process.env.MINIO_BUCKET) {
 }
 
 const MINIO_BUCKET = process.env.MINIO_BUCKET;
-const MANAGE_ROLES = [
+const MANAGE_ROLES = ["system", "head_of_admin", "admin", "branch_manager", "head_of_sale", "sale"];
-  "system",
-  "head_of_admin",
-  "admin",
-  "branch_admin",
-  "branch_manager",
-  "head_of_sale",
-  "sale",
-];
 
 function imageLocation(id: string) {
   return `employee/${id}/profile-image`;

src/controllers/employee-other-info-controller.ts

@@ -17,15 +17,7 @@ import HttpError from "../interfaces/http-error";
 import HttpStatus from "../interfaces/http-status";
 import { RequestWithUser } from "../interfaces/user";
 
-const MANAGE_ROLES = [
+const MANAGE_ROLES = ["system", "head_of_admin", "admin", "branch_manager", "head_of_sale", "sale"];
-  "system",
-  "head_of_admin",
-  "admin",
-  "branch_admin",
-  "branch_manager",
-  "head_of_sale",
-  "sale",
-];
 
 type EmployeeOtherInfoPayload = {
   citizenId?: string | null;

src/controllers/employee-work-controller.ts

@@ -16,15 +16,7 @@ import prisma from "../db";
 import HttpStatus from "../interfaces/http-status";
 import HttpError from "../interfaces/http-error";
 
-const MANAGE_ROLES = [
+const MANAGE_ROLES = ["system", "head_of_admin", "admin", "branch_manager", "head_of_sale", "sale"];
-  "system",
-  "head_of_admin",
-  "admin",
-  "branch_admin",
-  "branch_manager",
-  "head_of_sale",
-  "sale",
-];
 
 type EmployeeWorkPayload = {
   ownerName?: string | null;

src/controllers/product/product-controller.ts

@@ -29,7 +29,6 @@ const MANAGE_ROLES = [
   "system",
   "head_of_admin",
   "admin",
-  "branch_admin",
   "branch_manager",
   "head_of_account",
   "account",
@@ -87,8 +86,8 @@ function imageLocation(id: string) {
 }
 
 function globalAllow(roles?: string[]) {
-  return ["system", "head_of_admin", "admin", "branch_admin", "branch_manager", "head_of_account"].some(
+  return ["system", "head_of_admin", "admin", "branch_manager", "head_of_account"].some((v) =>
-    (v) => roles?.includes(v),
+    roles?.includes(v),
   );
 }
 

src/controllers/quotation-controller.ts

@@ -161,15 +161,14 @@ const MANAGE_ROLES = [
   "system",
   "head_of_admin",
   "admin",
-  "branch_admin",
   "branch_manager",
   "head_of_account",
   "account",
 ];
 
 function globalAllow(roles?: string[]) {
-  return ["system", "head_of_admin", "admin", "branch_admin", "branch_manager", "head_of_account"].some(
+  return ["system", "head_of_admin", "admin", "branch_manager", "head_of_account"].some((v) =>
-    (v) => roles?.includes(v),
+    roles?.includes(v),
   );
 }
 

src/controllers/service/service-controller.ts

@@ -29,7 +29,6 @@ const MANAGE_ROLES = [
   "system",
   "head_of_admin",
   "admin",
-  "branch_admin",
   "branch_manager",
   "head_of_account",
   "account",

src/controllers/user-controller.ts

@@ -724,7 +724,7 @@ export class UserController extends Controller {
   }
 
   @Put("{userId}/image")
-  @Security("keycloak", ["system", "head_of_admin", "admin", "branch_admin", "branch_manager"])
+  @Security("keycloak", ["system", "head_of_admin", "admin", "branch_manager"])
   async setUserImageByUserId(@Request() req: RequestWithUser, @Path() userId: string) {
     const record = await prisma.user.findFirst({
       include: {