From 0c80d8fbdb3839d08cfc2b242559cfae94f0c53a Mon Sep 17 00:00:00 2001 From: Methapon Metanipat Date: Wed, 4 Sep 2024 14:12:57 +0700 Subject: [PATCH] refactor: remove unused role --- src/controllers/customer-branch-controller.ts | 10 +--------- src/controllers/customer-controller.ts | 10 +--------- src/controllers/employee-checkup-controller.ts | 10 +--------- src/controllers/employee-controller.ts | 10 +--------- src/controllers/employee-other-info-controller.ts | 10 +--------- src/controllers/employee-work-controller.ts | 10 +--------- src/controllers/product/product-controller.ts | 5 ++--- src/controllers/quotation-controller.ts | 5 ++--- src/controllers/service/service-controller.ts | 1 - src/controllers/user-controller.ts | 2 +- 10 files changed, 11 insertions(+), 62 deletions(-) diff --git a/src/controllers/customer-branch-controller.ts b/src/controllers/customer-branch-controller.ts index d137400..188448f 100644 --- a/src/controllers/customer-branch-controller.ts +++ b/src/controllers/customer-branch-controller.ts @@ -24,15 +24,7 @@ if (!process.env.MINIO_BUCKET) { } const MINIO_BUCKET = process.env.MINIO_BUCKET; -const MANAGE_ROLES = [ - "system", - "head_of_admin", - "admin", - "branch_admin", - "branch_manager", - "head_of_sale", - "sale", -]; +const MANAGE_ROLES = ["system", "head_of_admin", "admin", "branch_manager", "head_of_sale", "sale"]; function imageLocation(id: string) { return `employee/profile-img-${id}`; diff --git a/src/controllers/customer-controller.ts b/src/controllers/customer-controller.ts index ef7b634..e067951 100644 --- a/src/controllers/customer-controller.ts +++ b/src/controllers/customer-controller.ts @@ -24,15 +24,7 @@ if (!process.env.MINIO_BUCKET) { } const MINIO_BUCKET = process.env.MINIO_BUCKET; -const MANAGE_ROLES = [ - "system", - "head_of_admin", - "admin", - "branch_admin", - "branch_manager", - "head_of_sale", - "sale", -]; +const MANAGE_ROLES = ["system", "head_of_admin", "admin", "branch_manager", "head_of_sale", "sale"]; export type CustomerCreate = { registeredBranchId?: string; diff --git a/src/controllers/employee-checkup-controller.ts b/src/controllers/employee-checkup-controller.ts index 309e858..d3799cc 100644 --- a/src/controllers/employee-checkup-controller.ts +++ b/src/controllers/employee-checkup-controller.ts @@ -16,15 +16,7 @@ import prisma from "../db"; import HttpStatus from "../interfaces/http-status"; import HttpError from "../interfaces/http-error"; -const MANAGE_ROLES = [ - "system", - "head_of_admin", - "admin", - "branch_admin", - "branch_manager", - "head_of_sale", - "sale", -]; +const MANAGE_ROLES = ["system", "head_of_admin", "admin", "branch_manager", "head_of_sale", "sale"]; type EmployeeCheckupPayload = { checkupType?: string | null; diff --git a/src/controllers/employee-controller.ts b/src/controllers/employee-controller.ts index 163cc0e..b6ea7e8 100644 --- a/src/controllers/employee-controller.ts +++ b/src/controllers/employee-controller.ts @@ -24,15 +24,7 @@ if (!process.env.MINIO_BUCKET) { } const MINIO_BUCKET = process.env.MINIO_BUCKET; -const MANAGE_ROLES = [ - "system", - "head_of_admin", - "admin", - "branch_admin", - "branch_manager", - "head_of_sale", - "sale", -]; +const MANAGE_ROLES = ["system", "head_of_admin", "admin", "branch_manager", "head_of_sale", "sale"]; function imageLocation(id: string) { return `employee/${id}/profile-image`; diff --git a/src/controllers/employee-other-info-controller.ts b/src/controllers/employee-other-info-controller.ts index 7867eb7..fe6c926 100644 --- a/src/controllers/employee-other-info-controller.ts +++ b/src/controllers/employee-other-info-controller.ts @@ -17,15 +17,7 @@ import HttpError from "../interfaces/http-error"; import HttpStatus from "../interfaces/http-status"; import { RequestWithUser } from "../interfaces/user"; -const MANAGE_ROLES = [ - "system", - "head_of_admin", - "admin", - "branch_admin", - "branch_manager", - "head_of_sale", - "sale", -]; +const MANAGE_ROLES = ["system", "head_of_admin", "admin", "branch_manager", "head_of_sale", "sale"]; type EmployeeOtherInfoPayload = { citizenId?: string | null; diff --git a/src/controllers/employee-work-controller.ts b/src/controllers/employee-work-controller.ts index cab015b..ef38448 100644 --- a/src/controllers/employee-work-controller.ts +++ b/src/controllers/employee-work-controller.ts @@ -16,15 +16,7 @@ import prisma from "../db"; import HttpStatus from "../interfaces/http-status"; import HttpError from "../interfaces/http-error"; -const MANAGE_ROLES = [ - "system", - "head_of_admin", - "admin", - "branch_admin", - "branch_manager", - "head_of_sale", - "sale", -]; +const MANAGE_ROLES = ["system", "head_of_admin", "admin", "branch_manager", "head_of_sale", "sale"]; type EmployeeWorkPayload = { ownerName?: string | null; diff --git a/src/controllers/product/product-controller.ts b/src/controllers/product/product-controller.ts index a1de62a..2246acf 100644 --- a/src/controllers/product/product-controller.ts +++ b/src/controllers/product/product-controller.ts @@ -29,7 +29,6 @@ const MANAGE_ROLES = [ "system", "head_of_admin", "admin", - "branch_admin", "branch_manager", "head_of_account", "account", @@ -87,8 +86,8 @@ function imageLocation(id: string) { } function globalAllow(roles?: string[]) { - return ["system", "head_of_admin", "admin", "branch_admin", "branch_manager", "head_of_account"].some( - (v) => roles?.includes(v), + return ["system", "head_of_admin", "admin", "branch_manager", "head_of_account"].some((v) => + roles?.includes(v), ); } diff --git a/src/controllers/quotation-controller.ts b/src/controllers/quotation-controller.ts index 12a4cdc..658bae4 100644 --- a/src/controllers/quotation-controller.ts +++ b/src/controllers/quotation-controller.ts @@ -161,15 +161,14 @@ const MANAGE_ROLES = [ "system", "head_of_admin", "admin", - "branch_admin", "branch_manager", "head_of_account", "account", ]; function globalAllow(roles?: string[]) { - return ["system", "head_of_admin", "admin", "branch_admin", "branch_manager", "head_of_account"].some( - (v) => roles?.includes(v), + return ["system", "head_of_admin", "admin", "branch_manager", "head_of_account"].some((v) => + roles?.includes(v), ); } diff --git a/src/controllers/service/service-controller.ts b/src/controllers/service/service-controller.ts index 140ed34..5657ff4 100644 --- a/src/controllers/service/service-controller.ts +++ b/src/controllers/service/service-controller.ts @@ -29,7 +29,6 @@ const MANAGE_ROLES = [ "system", "head_of_admin", "admin", - "branch_admin", "branch_manager", "head_of_account", "account", diff --git a/src/controllers/user-controller.ts b/src/controllers/user-controller.ts index 60c1b4e..a257b09 100644 --- a/src/controllers/user-controller.ts +++ b/src/controllers/user-controller.ts @@ -724,7 +724,7 @@ export class UserController extends Controller { } @Put("{userId}/image") - @Security("keycloak", ["system", "head_of_admin", "admin", "branch_admin", "branch_manager"]) + @Security("keycloak", ["system", "head_of_admin", "admin", "branch_manager"]) async setUserImageByUserId(@Request() req: RequestWithUser, @Path() userId: string) { const record = await prisma.user.findFirst({ include: {