แก้ตามผลใช้งานจริง 2 ประเด็น: 1. เปิดใน Word ทันที — generate-draft เปลี่ยนจากคืนไฟล์ตรงๆ เป็นเก็บ ชั่วคราวใต้ drafts/ (lifecycle ลบรายวัน, config Minio__DraftRetentionDays) + คืน presigned URL ให้เว็บเปิดผ่าน ms-word:ofe พร้อมลิงก์สำรอง (useVersionOpen.openDocxUrl แยกแกนเปิด docx URL ใช้ร่วมกับ flow v0) 2. ตัดคำไทย — T14 แตก placeholder เป็น [ / ข้อความ / ] โดย run ข้อความ ถือ w:hint="cs" + w:cs เท่านั้น; เดิมเขียนค่าลง run ปีกกาทำให้ Word จัดหน้าไทยผิด — แก้เป็นเขียนที่ run ข้อความยาวสุด + SDT เปล่าสืบทอด rPr จาก sdtPr (ใช้ร่วมทั้ง generate และ generate-draft) - ถอดของที่เลิกใช้: CORS expose Content-Disposition, downloadFile init, useApi.spec · Spec v9 + ADR 0002 Amendment + acceptance-review AC-19 - Tests: backend 84 / web 56 + build; QA reviewer PASS (2 rounds, 10 findings แก้ครบ — รวม bug จริงที่ test ใหม่จับได้: lifecycle Rules null ทำ startup ตั้ง rule ล้มแบบเงียบ) · ค้าง manual บน Word จริง Co-Authored-By: Claude Code <noreply@anthropic.com>
110 lines
4.6 KiB
TypeScript
110 lines
4.6 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { createApp, type App } from 'vue'
|
|
import { useVersionOpen } from '../app/composables/useVersionOpen'
|
|
|
|
let app: App
|
|
let host: HTMLDivElement
|
|
const apiJson = vi.fn()
|
|
const replace = vi.fn()
|
|
const close = vi.fn()
|
|
let tab: { opener: unknown; closed: boolean; location: { replace: typeof replace }; close: typeof close }
|
|
|
|
function mount() {
|
|
let result!: ReturnType<typeof useVersionOpen>
|
|
host = document.createElement('div')
|
|
document.body.append(host)
|
|
app = createApp({ setup() { result = useVersionOpen(); return () => null } })
|
|
app.mount(host)
|
|
return result
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.useFakeTimers()
|
|
vi.stubGlobal('useApi', () => ({ apiJson }))
|
|
tab = { opener: {}, closed: false, location: { replace }, close }
|
|
vi.spyOn(window, 'open').mockReturnValue(tab as unknown as Window)
|
|
})
|
|
afterEach(() => {
|
|
app?.unmount()
|
|
host?.remove()
|
|
vi.restoreAllMocks()
|
|
vi.unstubAllGlobals()
|
|
vi.clearAllMocks()
|
|
vi.useRealTimers()
|
|
})
|
|
|
|
describe('version open lifecycle', () => {
|
|
it('reserves PDF tab synchronously, navigates after auth, leaves completed PDF open on unmount', async () => {
|
|
let resolve!: (value: unknown) => void
|
|
apiJson.mockReturnValue(new Promise(r => { resolve = r }))
|
|
const state = mount()
|
|
const pending = state.openVersion('d', 'v', 'pdf')
|
|
expect(window.open).toHaveBeenCalledWith('about:blank', '_blank')
|
|
expect(tab.opener).toBeNull()
|
|
expect(state.openingVersionId.value).toBe('v')
|
|
resolve({ url: 'https://files.example/v.pdf' })
|
|
await pending
|
|
expect(replace).toHaveBeenCalledWith('https://files.example/v.pdf')
|
|
expect(state.fallbackUrl.value).toBe('https://files.example/v.pdf')
|
|
app.unmount()
|
|
expect(close).not.toHaveBeenCalled()
|
|
})
|
|
it('keeps a fallback when popup is blocked', async () => {
|
|
vi.mocked(window.open).mockReturnValue(null)
|
|
apiJson.mockResolvedValue({ url: 'https://files.example/v.pdf' })
|
|
const state = mount()
|
|
await state.openVersion('d', 'v', 'pdf')
|
|
expect(state.openNotice.value).toBeTruthy()
|
|
expect(state.fallbackUrl.value).toBe('https://files.example/v.pdf')
|
|
})
|
|
it('closes pending tab immediately on reset and ignores a late response', async () => {
|
|
let resolve!: (value: unknown) => void
|
|
apiJson.mockReturnValue(new Promise(r => { resolve = r }))
|
|
const state = mount()
|
|
const pending = state.openVersion('d', 'v', 'pdf')
|
|
state.resetOpen()
|
|
expect(close).toHaveBeenCalledTimes(1)
|
|
resolve({ url: 'https://files.example/v.pdf' })
|
|
await pending
|
|
expect(replace).not.toHaveBeenCalled()
|
|
expect(state.fallbackUrl.value).toBeNull()
|
|
})
|
|
it('closes reserved tab and reports request failure', async () => {
|
|
apiJson.mockRejectedValue(new Error('offline'))
|
|
const state = mount()
|
|
await state.openVersion('d', 'v', 'pdf')
|
|
expect(close).toHaveBeenCalled()
|
|
expect(state.downloadError.value).toBe('offline')
|
|
expect(state.openingVersionId.value).toBeNull()
|
|
})
|
|
it('handles synchronous popup errors and restores controls', async () => {
|
|
vi.mocked(window.open).mockImplementation(() => { throw new Error('popup error') })
|
|
const state = mount()
|
|
await state.openVersion('d', 'v', 'pdf')
|
|
expect(state.downloadError.value).toBe('popup error')
|
|
expect(state.openingVersionId.value).toBeNull()
|
|
})
|
|
it('offers Word fallback after timeout and removes listeners on unmount', async () => {
|
|
const assign = vi.spyOn(window.location, 'assign').mockImplementation(() => {})
|
|
const remove = vi.spyOn(window, 'removeEventListener')
|
|
apiJson.mockResolvedValue({ url: 'https://files.example/v.docx?signature=a%2Fb' })
|
|
const state = mount()
|
|
await state.openVersion('d', 'v')
|
|
expect(assign).toHaveBeenCalledWith('ms-word:ofe|u|https://files.example/v.docx?signature=a%2Fb')
|
|
vi.advanceTimersByTime(1500)
|
|
expect(state.openNotice.value).toBeTruthy()
|
|
expect(state.fallbackUrl.value).toBeTruthy()
|
|
app.unmount()
|
|
expect(remove).toHaveBeenCalledWith('blur', expect.any(Function))
|
|
})
|
|
it('openDocxUrl opens a URL the caller already holds (ไฟล์ร่าง FR-16) without extra request', async () => {
|
|
const assign = vi.spyOn(window.location, 'assign').mockImplementation(() => {})
|
|
const state = mount()
|
|
state.openDocxUrl('https://files.example/draft.docx?sig=a%2Fb')
|
|
expect(apiJson).not.toHaveBeenCalled()
|
|
expect(assign).toHaveBeenCalledWith('ms-word:ofe|u|https://files.example/draft.docx?sig=a%2Fb')
|
|
expect(state.fallbackUrl.value).toBe('https://files.example/draft.docx?sig=a%2Fb')
|
|
vi.advanceTimersByTime(1500)
|
|
expect(state.openNotice.value).toBeTruthy()
|
|
})
|
|
})
|