From 47fe2f8f0a088682573cc94b76523e33b9dbffe7 Mon Sep 17 00:00:00 2001
From: Methapon2001 <61303214+Methapon2001@users.noreply.github.com>
Date: Mon, 11 Dec 2023 10:11:32 +0700
Subject: [PATCH] refactor: code readability

---
 Services/client/src/components/FileIcon.vue | 43 ++++++++-------------
 1 file changed, 16 insertions(+), 27 deletions(-)

diff --git a/Services/client/src/components/FileIcon.vue b/Services/client/src/components/FileIcon.vue
index c8c6957..7c524a5 100644
--- a/Services/client/src/components/FileIcon.vue
+++ b/Services/client/src/components/FileIcon.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
-import { useFileInfoStore } from '@/stores/file-info-data'
 import mime from 'mime'
+import { useFileInfoStore } from '@/stores/file-info-data'
 
 const { mimeFileMapping } = useFileInfoStore()
 
@@ -11,44 +11,33 @@ defineProps<{
 }>()
 
 function getIcon(mimeType: string | undefined, fileName: string | undefined) {
-  if (mimeType === undefined) {
-    return 'mdi-file-question-outline'
-  }
+  if (!mimeType) return 'mdi-file-question-outline'
+
+  const extension = mime.getExtension(mimeType)
+
+  if (extension) return mimeFileMapping[mimeType].icon
+  if (fileName && fileName.includes('.')) return 'mdi-file-outline'
 
-  const extFomMime = mime.getExtension(mimeType)
-  if (extFomMime) {
-    return mimeFileMapping[mimeType].icon
-  }
-  if (fileName && fileName.includes('.')) {
-    return 'mdi-file-outline'
-  }
   return 'mdi-file-question-outline'
 }
 
 function getColor(mimeType: string | undefined, fileName: string | undefined) {
-  if (mimeType === undefined) {
-    return 'grey-5'
-  }
+  if (mimeType === undefined) return 'grey-5'
+
+  const extension = mime.getExtension(mimeType)
+
+  if (extension) return mimeFileMapping[mimeType].color
+  if (fileName && fileName.includes('.')) return 'blue-11'
 
-  const extFomMime = mime.getExtension(mimeType)
-  if (extFomMime) {
-    return mimeFileMapping[mimeType].color
-  }
-  if (fileName && fileName.includes('.')) {
-    return 'blue-11'
-  }
   return 'grey-5'
 }
 
-function getIconSize(s: string) {
-  type SizeMapping = {
-    [key: string]: string
-  }
-  const sizeMapping: SizeMapping = {
+function getIconSize(size: string) {
+  const sizeMapping = {
     preview: '6em',
     list: '2em',
   }
-  return sizeMapping[s]
+  return sizeMapping[size as keyof typeof sizeMapping]
 }
 </script>