diff --git a/.claude/agent-memory/hrms-checkin-expert/MEMORY.md b/.claude/agent-memory/hrms-checkin-expert/MEMORY.md index 7897460..bb4f782 100644 --- a/.claude/agent-memory/hrms-checkin-expert/MEMORY.md +++ b/.claude/agent-memory/hrms-checkin-expert/MEMORY.md @@ -7,3 +7,8 @@ ## Project Issues & Fixes - [Position Orientation Change Fix](issue_position_orientation_change_fix.md) - Fix for position map not displaying on screen orientation changes +- [Active Camera Scope](project_active_camera_scope.md) - Current camera issue work should stay in HomeView.vue, not legacy MapView.vue +- [Front Camera Preview Alignment](issue_front_camera_preview_alignment.md) - Keep popup preview orientation aligned with normalized saved photos +- [iOS Native Photo Mirroring](issue_ios_native_photo_mirroring.md) - Do not flip iOS native-capture photos during normalization +- [iOS Native Camera Popup](issue_ios_native_camera_popup_control.md) - Inline-first on iOS; native activates only after inline fails (prior native-first seed was reverted) +- [iOS 16 Inline White Preview](issue_ios16_inline_camera_white_preview.md) - Safari iOS 16 white preview needs single mount plus explicit video readiness diff --git a/.claude/agent-memory/hrms-checkin-expert/issue_front_camera_preview_alignment.md b/.claude/agent-memory/hrms-checkin-expert/issue_front_camera_preview_alignment.md new file mode 100644 index 0000000..f78b23d --- /dev/null +++ b/.claude/agent-memory/hrms-checkin-expert/issue_front_camera_preview_alignment.md @@ -0,0 +1,11 @@ +--- +name: front_camera_preview_alignment +description: HomeView inline camera flow should show a non-mirrored preview and keep the saved/uploaded image in the same orientation the user saw while shooting +type: project +--- + +When fixing front-camera capture issues in `HomeView.vue`, keep the in-page preview and the final saved/uploaded image in the same non-mirrored orientation. + +**Why:** Users rejected flows where the live in-page preview looked mirrored or differed from the final image. The expected behavior is “what I see while shooting is what gets used.” + +**How to apply:** In the inline `simple-vue-camera` flow, avoid extra front-camera mirroring in either preview styling or snapshot normalization. Treat the in-page preview as the canonical orientation for `img`/`fileImg`. diff --git a/.claude/agent-memory/hrms-checkin-expert/issue_ios16_inline_camera_white_preview.md b/.claude/agent-memory/hrms-checkin-expert/issue_ios16_inline_camera_white_preview.md new file mode 100644 index 0000000..791f98e --- /dev/null +++ b/.claude/agent-memory/hrms-checkin-expert/issue_ios16_inline_camera_white_preview.md @@ -0,0 +1,11 @@ +--- +name: ios16-inline-camera-white-preview +description: Safari iOS 16 inline preview can stay white when multiple simple-vue-camera instances mount and playback readiness is assumed too early +type: project +--- + +In `HomeView.vue`, Safari on iOS 16.x can show a white in-page camera preview when more than one `simple-vue-camera` instance is mounted for responsive layouts and the app treats `camera.start()` as sufficient proof that the preview is rendering. + +**Why:** `simple-vue-camera` uses a hard-coded `id="video"` internally and does not explicitly call `video.play()` during `start()`. On mobile/xs, mounting both desktop and mobile camera components at once creates a fragile setup for Safari, where the active preview can remain white even though permission and stream startup succeeded. + +**How to apply:** Keep only the active responsive camera instance mounted in `HomeView.vue`, and after `camera.start()` explicitly prepare/check the underlying video element (`playsinline`, `muted`, `play()`, non-zero dimensions, ready state). If the preview still does not become render-ready, remount once and then fall back to native capture. diff --git a/.claude/agent-memory/hrms-checkin-expert/issue_ios_native_camera_popup_control.md b/.claude/agent-memory/hrms-checkin-expert/issue_ios_native_camera_popup_control.md new file mode 100644 index 0000000..22792d0 --- /dev/null +++ b/.claude/agent-memory/hrms-checkin-expert/issue_ios_native_camera_popup_control.md @@ -0,0 +1,11 @@ +--- +name: ios_native_camera_popup_control +description: iOS uses inline camera first (same as Android); native fallback triggers only after inline fails. The prior "native-first on iOS" approach was reverted per product requirement. +type: project +--- + +In `HomeView.vue`, the inline camera is **always attempted first** on iOS (and every other platform). The hidden `` is only activated by `switchToNativePhotoCapture()` / `enableNativePhotoCaptureFallback()` after inline capture is proven to fail. + +**Why:** The product requirement is "use inline camera whenever the device supports inline capture; use native device capture only when inline is not supported or fails." iOS Safari supports `getUserMedia` since iOS 14.3, so inline-first is viable. A prior session hard-coded `useNativePhotoCapture = computed(() => isIOSDevice || preferNativePhotoCapture.value)`, bypassing inline on iOS entirely — that line was reverted. + +**How to apply:** `preferNativePhotoCapture` must start `false` on all devices. Never seed it with `isIOSDevice`. All failure paths (`openCamera` permission denied, `camera.start()` throw, invalid snapshot blob, invalid image on submit) already call `switchToNativePhotoCapture()` which sets `preferNativePhotoCapture = true` so subsequent taps go directly to native — covering the first-tap fallback automatically. diff --git a/.claude/agent-memory/hrms-checkin-expert/issue_ios_native_photo_mirroring.md b/.claude/agent-memory/hrms-checkin-expert/issue_ios_native_photo_mirroring.md new file mode 100644 index 0000000..77f33ef --- /dev/null +++ b/.claude/agent-memory/hrms-checkin-expert/issue_ios_native_photo_mirroring.md @@ -0,0 +1,11 @@ +--- +name: ios_native_photo_mirroring +description: Native photo capture on iOS in HomeView should not be horizontally mirrored during normalization +type: project +--- + +For `HomeView.vue`, native photo capture on iOS should not apply horizontal mirroring during image normalization. + +**Why:** The iOS fallback uses the native still-photo picker, and the returned photo can already be in the correct orientation. Applying the same mirror correction used for other front-camera paths flips the image incorrectly on iOS. + +**How to apply:** Keep platform-specific normalization for native capture. Do not assume the iOS file-input photo path behaves the same as `simple-vue-camera` snapshots or Android fallback capture. diff --git a/.claude/agent-memory/hrms-checkin-expert/project_active_camera_scope.md b/.claude/agent-memory/hrms-checkin-expert/project_active_camera_scope.md new file mode 100644 index 0000000..a10c142 --- /dev/null +++ b/.claude/agent-memory/hrms-checkin-expert/project_active_camera_scope.md @@ -0,0 +1,11 @@ +--- +name: Active camera investigation scope +description: Current camera issue investigations should focus on HomeView.vue; the legacy Google Map MapView.vue flow is not in active use +type: project +--- + +Current camera issue work should focus on `HomeView.vue`; do not investigate or modify the legacy Google Map `MapView.vue` flow for this issue. + +**Why:** The user clarified that `MapView.vue` is an older Google Map implementation from earlier work and is not the path currently used in production for this check-in flow. + +**How to apply:** For follow-up debugging or fixes related to the current camera/upload issue, scope analysis and implementation to `HomeView.vue` unless the user explicitly re-opens `MapView.vue`. diff --git a/src/composables/usePermissions.ts b/src/composables/usePermissions.ts index ecf1ef3..b92ed29 100644 --- a/src/composables/usePermissions.ts +++ b/src/composables/usePermissions.ts @@ -1,52 +1,171 @@ -import { useQuasar } from 'quasar' +import { onBeforeUnmount, ref } from 'vue' import { usePrivacyStore } from '@/stores/privacy' +type BrowserPermissionState = PermissionState | 'unsupported' + +type PermissionQueryName = 'camera' | 'geolocation' + export function usePermissions() { - const $q = useQuasar() const privacyStore = usePrivacyStore() + const cameraPermissionState = ref('prompt') + const locationPermissionState = ref('prompt') - // const checkCameraPermission = (): boolean => { - // if (!privacyStore.isAccepted) { - // privacyStore.modalPrivacy = true - // $q.notify({ - // type: 'warning', - // message: 'กรุณายอมรับนโยบายคุ้มครองข้อมูลส่วนบุคคลก่อนใช้งานกล้อง', - // position: 'top', - // }) - // return false - // } - // return true - // } + let cameraPermissionStatus: PermissionStatus | null = null + let locationPermissionStatus: PermissionStatus | null = null - // const checkLocationPermission = (): boolean => { - // if (!privacyStore.isAccepted) { - // privacyStore.modalPrivacy = true - // $q.notify({ - // type: 'warning', - // message: 'กรุณายอมรับนโยบายคุ้มครองข้อมูลส่วนบุคคลก่อนใช้งานแผนที่', - // position: 'top', - // }) - // return false - // } - // return true - // } + const isPermissionsApiSupported = () => + typeof navigator !== 'undefined' && 'permissions' in navigator + + const setPermissionState = ( + target: typeof cameraPermissionState | typeof locationPermissionState, + state: BrowserPermissionState + ) => { + target.value = state + } + + const setPermissionChangeListener = ( + name: PermissionQueryName, + status: PermissionStatus + ) => { + status.onchange = () => { + const target = + name === 'camera' ? cameraPermissionState : locationPermissionState + setPermissionState(target, status.state) + } + } + + async function queryPermissionState(name: PermissionQueryName) { + if (!isPermissionsApiSupported()) { + return null + } + + try { + return await navigator.permissions.query({ name } as PermissionDescriptor) + } catch (error) { + return null + } + } + + async function syncPermissionState(name: PermissionQueryName) { + const target = + name === 'camera' ? cameraPermissionState : locationPermissionState + const previousStatus = + name === 'camera' ? cameraPermissionStatus : locationPermissionStatus + + if (previousStatus) { + previousStatus.onchange = null + } + + const status = await queryPermissionState(name) + if (!status) { + if (target.value === 'prompt') { + setPermissionState(target, 'unsupported') + } + return + } + + if (name === 'camera') { + cameraPermissionStatus = status + } else { + locationPermissionStatus = status + } + + setPermissionState(target, status.state) + setPermissionChangeListener(name, status) + } + + async function syncPermissionStates() { + await Promise.all([ + syncPermissionState('camera'), + syncPermissionState('geolocation'), + ]) + } const checkPrivacyAccepted = (): boolean => { if (!privacyStore.isAccepted) { privacyStore.modalPrivacy = true - // $q.notify({ - // type: 'warning', - // message: 'กรุณายอมรับนโยบายคุ้มครองข้อมูลส่วนบุคคลก่อนใช้งาน', - // position: 'center', - // }) return false } return true } + async function requestCameraPermission() { + if (!checkPrivacyAccepted()) { + return false + } + + if (cameraPermissionState.value === 'granted') { + return true + } + + if (!navigator.mediaDevices?.getUserMedia) { + setPermissionState(cameraPermissionState, 'unsupported') + return false + } + + try { + const stream = await navigator.mediaDevices.getUserMedia({ + video: { facingMode: 'user' }, + audio: false, + }) + + stream.getTracks().forEach((track) => track.stop()) + setPermissionState(cameraPermissionState, 'granted') + return true + } catch (error) { + setPermissionState(cameraPermissionState, 'denied') + return false + } finally { + await syncPermissionState('camera') + } + } + + async function requestLocationPermission() { + if (!checkPrivacyAccepted()) { + return false + } + + if (locationPermissionState.value === 'granted') { + return true + } + + if (!navigator.geolocation) { + setPermissionState(locationPermissionState, 'unsupported') + return false + } + + return new Promise((resolve) => { + navigator.geolocation.getCurrentPosition( + async () => { + setPermissionState(locationPermissionState, 'granted') + await syncPermissionState('geolocation') + resolve(true) + }, + async () => { + setPermissionState(locationPermissionState, 'denied') + await syncPermissionState('geolocation') + resolve(false) + } + ) + }) + } + + onBeforeUnmount(() => { + if (cameraPermissionStatus) { + cameraPermissionStatus.onchange = null + } + + if (locationPermissionStatus) { + locationPermissionStatus.onchange = null + } + }) + return { - // checkCameraPermission, - // checkLocationPermission, + cameraPermissionState, + locationPermissionState, checkPrivacyAccepted, + syncPermissionStates, + requestCameraPermission, + requestLocationPermission, } } diff --git a/src/views/HomeView.vue b/src/views/HomeView.vue index ab7257f..9b76ae3 100644 --- a/src/views/HomeView.vue +++ b/src/views/HomeView.vue @@ -1,5 +1,13 @@