remove try catch

src/controllers/PosLevelController.ts

@@ -32,9 +32,7 @@ import { Not } from "typeorm";
   "เกิดข้อผิดพลาด ไม่สามารถแสดงรายการได้ กรุณาลองใหม่ในภายหลัง",
 )
 @SuccessResponse(HttpStatusCode.OK, "สำเร็จ")
-
 export class PosLevelController extends Controller {
-
   private posTypeRepository = AppDataSource.getRepository(PosType);
   private posLevelRepository = AppDataSource.getRepository(PosLevel);
 
@@ -45,14 +43,12 @@ export class PosLevelController extends Controller {
    *
    */
   @Post()
-  @Example(
-    {
-      posLevelName: "นักบริหาร",
-      posLevelRank: 1,
-      posLevelAuthority: "HEAD",
-      posTypeId: "08db9e81-fc46-4e95-8b33-be4ca0016abf"
-    },
-  )
+  @Example({
+    posLevelName: "นักบริหาร",
+    posLevelRank: 1,
+    posLevelAuthority: "HEAD",
+    posTypeId: "08db9e81-fc46-4e95-8b33-be4ca0016abf",
+  })
   async createLevel(
     @Body()
     requestBody: CreatePosLevel,
@@ -62,19 +58,29 @@ export class PosLevelController extends Controller {
     if (!posLevel) {
       throw new HttpError(HttpStatusCode.NOT_FOUND, "ไม่พบข้อมูล");
     }
-    const chkPosTypeId = await this.posTypeRepository.findOne({ where: { 
-      id: requestBody.posTypeId } 
-    })
-    if(!chkPosTypeId){
-      throw new HttpError(HttpStatusCode.NOT_FOUND, "ไม่พบข้อมูล posTypeId ไอดีนี้ : " + requestBody.posTypeId);
+    const chkPosTypeId = await this.posTypeRepository.findOne({
+      where: {
+        id: requestBody.posTypeId,
+      },
+    });
+    if (!chkPosTypeId) {
+      throw new HttpError(
+        HttpStatusCode.NOT_FOUND,
+        "ไม่พบข้อมูล posTypeId ไอดีนี้ : " + requestBody.posTypeId,
+      );
     }
 
-    const chkPosLevelName = await this.posLevelRepository.findOne({ where: { 
-      posTypeId: requestBody.posTypeId, //ระดับประเภทเดียวกัน ชื่อระดับตำแหน่ง ห้ามซ้ำ
-      posLevelName: requestBody.posLevelName } 
-    })
-    if(chkPosLevelName){
-      throw new HttpError(HttpStatusCode.NOT_FOUND, "ชื่อระดับตำแหน่ง: " + requestBody.posLevelName + " มีอยู่ในระบบแล้ว");
+    const chkPosLevelName = await this.posLevelRepository.findOne({
+      where: {
+        posTypeId: requestBody.posTypeId, //ระดับประเภทเดียวกัน ชื่อระดับตำแหน่ง ห้ามซ้ำ
+        posLevelName: requestBody.posLevelName,
+      },
+    });
+    if (chkPosLevelName) {
+      throw new HttpError(
+        HttpStatusCode.NOT_FOUND,
+        "ชื่อระดับตำแหน่ง: " + requestBody.posLevelName + " มีอยู่ในระบบแล้ว",
+      );
     }
 
     const validPosLevelAuthority = ["HEAD", "DEPUTY", "GOVERNOR"];
@@ -85,16 +91,12 @@ export class PosLevelController extends Controller {
       throw new HttpError(HttpStatusCode.NOT_FOUND, "not found. posLevelAuthority");
     }
 
-    try {
-      posLevel.createdUserId = request.user.sub;
-      posLevel.createdFullName = request.user.name;
-      posLevel.lastUpdateUserId = request.user.sub;
-      posLevel.lastUpdateFullName = request.user.name;
-      await this.posLevelRepository.save(posLevel);
-      return new HttpSuccess(posLevel);
-    } catch (error) {
-      return error;
-    }
+    posLevel.createdUserId = request.user.sub;
+    posLevel.createdFullName = request.user.name;
+    posLevel.lastUpdateUserId = request.user.sub;
+    posLevel.lastUpdateFullName = request.user.name;
+    await this.posLevelRepository.save(posLevel);
+    return new HttpSuccess(posLevel);
   }
 
   /**
@@ -105,12 +107,10 @@ export class PosLevelController extends Controller {
    * @param {string} id  Id ระดับตำแหน่ง
    */
   @Put("{id}")
-  @Example(
-    {
-      positionName: "นักบริหาร",
-      posTypeRank: 1,
-    },
-  )
+  @Example({
+    positionName: "นักบริหาร",
+    posTypeRank: 1,
+  })
   async editLevel(
     @Path() id: string,
     @Body() requestBody: UpdatePosLevel,
@@ -121,20 +121,30 @@ export class PosLevelController extends Controller {
       throw new HttpError(HttpStatusCode.NOT_FOUND, "ไม่พบข้อมูลไอดีนี้ : " + id);
     }
 
-    const chkPosTypeId = await this.posTypeRepository.findOne({ where: { 
-      id: requestBody.posTypeId } 
-    })
-    if(!chkPosTypeId){
-      throw new HttpError(HttpStatusCode.NOT_FOUND, "ไม่พบข้อมูล posTypeId ไอดีนี้ : " + requestBody.posTypeId);
+    const chkPosTypeId = await this.posTypeRepository.findOne({
+      where: {
+        id: requestBody.posTypeId,
+      },
+    });
+    if (!chkPosTypeId) {
+      throw new HttpError(
+        HttpStatusCode.NOT_FOUND,
+        "ไม่พบข้อมูล posTypeId ไอดีนี้ : " + requestBody.posTypeId,
+      );
     }
 
-    const chkPosLevelName = await this.posLevelRepository.findOne({ where: { 
-      id: Not(id),
-      posTypeId: requestBody.posTypeId,
-      posLevelName: requestBody.posLevelName } 
-    })
-    if(chkPosLevelName){
-      throw new HttpError(HttpStatusCode.NOT_FOUND, "ชื่อระดับตำแหน่ง: " + requestBody.posLevelName + " มีอยู่ในระบบแล้ว");
+    const chkPosLevelName = await this.posLevelRepository.findOne({
+      where: {
+        id: Not(id),
+        posTypeId: requestBody.posTypeId,
+        posLevelName: requestBody.posLevelName,
+      },
+    });
+    if (chkPosLevelName) {
+      throw new HttpError(
+        HttpStatusCode.NOT_FOUND,
+        "ชื่อระดับตำแหน่ง: " + requestBody.posLevelName + " มีอยู่ในระบบแล้ว",
+      );
     }
     const validPosLevelAuthority = ["HEAD", "DEPUTY", "GOVERNOR"];
     if (
@@ -144,15 +154,11 @@ export class PosLevelController extends Controller {
       throw new HttpError(HttpStatusCode.NOT_FOUND, "not found. posLevelAuthority");
     }
 
-    try {
-      posLevel.lastUpdateUserId = request.user.sub;
-      posLevel.lastUpdateFullName = request.user.name;
-      this.posLevelRepository.merge(posLevel, requestBody);
-      await this.posLevelRepository.save(posLevel);
-      return new HttpSuccess(posLevel.id);
-    } catch (error) {
-      return error;
-    }
+    posLevel.lastUpdateUserId = request.user.sub;
+    posLevel.lastUpdateFullName = request.user.name;
+    this.posLevelRepository.merge(posLevel, requestBody);
+    await this.posLevelRepository.save(posLevel);
+    return new HttpSuccess(posLevel.id);
   }
 
   /**
@@ -168,12 +174,8 @@ export class PosLevelController extends Controller {
     if (!delPosLevel) {
       throw new HttpError(HttpStatusCode.NOT_FOUND, "ไม่พบข้อมูลไอดีนี้ : " + id);
     }
-    try {
-      await this.posLevelRepository.remove(delPosLevel);
-      return new HttpSuccess();
-    } catch (error) {
-      return error;
-    }
+    await this.posLevelRepository.remove(delPosLevel);
+    return new HttpSuccess();
   }
 
   /**
@@ -184,46 +186,40 @@ export class PosLevelController extends Controller {
    * @param {string} id  Id ระดับตำแหน่ง
    */
   @Get("{id}")
-  @Example(
-    {
+  @Example({
+    id: "00000000-0000-0000-0000-000000000000",
+    posLevelName: "นักบริหาร",
+    posLevelRank: 1,
+    posLevelAuthority: "HEAD",
+    posTypes: {
       id: "00000000-0000-0000-0000-000000000000",
-      posLevelName: "นักบริหาร",
-      posLevelRank: 1,
-      posLevelAuthority: "HEAD",
-      posTypes: {
-        id: "00000000-0000-0000-0000-000000000000",
-        posTypeName: "นักบริหาร",
-        posTypeRank: 1,
-      },
+      posTypeName: "นักบริหาร",
+      posTypeRank: 1,
     },
-  )
+  })
   async GetLevelDetail(@Path() id: string) {
-    try {
-      const getPosType = await this.posLevelRepository.findOne({
-        select: ["id", "posLevelName", "posLevelRank", "posLevelAuthority"],
-        relations: ["posType"],
-        where: { id: id }
-      });
-      if (!getPosType) {
-        throw new HttpError(HttpStatusCode.NOT_FOUND, "ไม่พบข้อมูลไอดีนี้ : " + id);
-      }
-
-      const mapPosLevel = {
-        id: getPosType.id,
-        posLevelName: getPosType.posLevelName,
-        posLevelRank: getPosType.posLevelRank,
-        posLevelAuthority: getPosType.posLevelAuthority,
-        posTypes:{
-          id: getPosType.posType.id,
-          posTypeName: getPosType.posType.posTypeName,
-          posTypeRank: getPosType.posType.posTypeRank
-        }
-      }
-
-      return new HttpSuccess(mapPosLevel);
-    } catch (error) {
-      return error;
+    const getPosType = await this.posLevelRepository.findOne({
+      select: ["id", "posLevelName", "posLevelRank", "posLevelAuthority"],
+      relations: ["posType"],
+      where: { id: id },
+    });
+    if (!getPosType) {
+      throw new HttpError(HttpStatusCode.NOT_FOUND, "ไม่พบข้อมูลไอดีนี้ : " + id);
     }
+
+    const mapPosLevel = {
+      id: getPosType.id,
+      posLevelName: getPosType.posLevelName,
+      posLevelRank: getPosType.posLevelRank,
+      posLevelAuthority: getPosType.posLevelAuthority,
+      posTypes: {
+        id: getPosType.posType.id,
+        posTypeName: getPosType.posType.posTypeName,
+        posTypeRank: getPosType.posType.posTypeRank,
+      },
+    };
+
+    return new HttpSuccess(mapPosLevel);
   }
 
   /**
@@ -247,28 +243,24 @@ export class PosLevelController extends Controller {
     },
   ])
   async GetPosLevel() {
-    try {
-      const posLevel = await this.posLevelRepository.find({
-        select: ["id", "posLevelName", "posLevelRank", "posLevelAuthority", "posTypeId"],
-        relations: ["posType"],
-      });
-      if (!posLevel) {
-        return new HttpSuccess([]);
-      }
-      const mapPosLevel = posLevel.map((item) => ({
-        id: item.id,
-        posLevelName: item.posLevelName,
-        posLevelRank: item.posLevelRank,
-        posLevelAuthority: item.posLevelAuthority,
-        posTypes: {
-          id: item.posType.id,
-          posTypeName: item.posType.posTypeName,
-          posTypeRank: item.posType.posTypeRank,
-        }
-      }));
-      return new HttpSuccess(mapPosLevel);
-    } catch (error) {
-      return error;
+    const posLevel = await this.posLevelRepository.find({
+      select: ["id", "posLevelName", "posLevelRank", "posLevelAuthority", "posTypeId"],
+      relations: ["posType"],
+    });
+    if (!posLevel) {
+      return new HttpSuccess([]);
     }
+    const mapPosLevel = posLevel.map((item) => ({
+      id: item.id,
+      posLevelName: item.posLevelName,
+      posLevelRank: item.posLevelRank,
+      posLevelAuthority: item.posLevelAuthority,
+      posTypes: {
+        id: item.posType.id,
+        posTypeName: item.posType.posTypeName,
+        posTypeRank: item.posType.posTypeRank,
+      },
+    }));
+    return new HttpSuccess(mapPosLevel);
   }
 }