fixed service crash

src/controllers/AuthRoleController.ts

@@ -130,12 +130,12 @@ export class AuthRoleController extends Controller {
           port: REDIS_PORT,
         });
 
-        redisClient.del("role_" + posMaster.current_holderId, (err: Error, response: Response) => {
+        redisClient.del("role_" + posMaster.current_holderId, (err: Error) => {
-          if (err) throw err;
+          if (err) console.error("Redis delete role error:", err);
         });
 
-        redisClient.del("menu_" + posMaster.current_holderId, (err: Error, response: Response) => {
+        redisClient.del("menu_" + posMaster.current_holderId, (err: Error) => {
-          if (err) throw err;
+          if (err) console.error("Redis delete menu error:", err);
         });
       } finally {
         if (redisClient) {

src/controllers/CommandOperatorController.ts

@@ -9,7 +9,7 @@ import {
   Path,
   Request,
   Response,
-  Get
+  Get,
 } from "tsoa";
 import { LessThan, MoreThan } from "typeorm";
 import { AppDataSource } from "../database/data-source";
@@ -37,9 +37,7 @@ export class CommandOperatorController extends Controller {
    * @param commandId คีย์คำสั่ง
    */
   @Get("{commandId}")
-  async getCommandOperatorByCommandId(
+  async getCommandOperatorByCommandId(@Path() commandId: string) {
-    @Path() commandId: string
-  ) {
     const command = await this.commandRepo.findOne({
       where: { id: commandId },
       select: { id: true },
@@ -61,10 +59,7 @@ export class CommandOperatorController extends Controller {
    * @param operatorId คีย์เจ้าหน้าที่ดำเนินการ
    */
   @Get("swap/{direction}/{operatorId}")
-  async swapCommandOperator(
+  async swapCommandOperator(@Path() direction: string, @Path() operatorId: string) {
-    @Path() direction: string,
-    @Path() operatorId: string,
-  ) {
     const source = await this.commandOperatorRepo.findOne({
       where: { id: operatorId },
     });
@@ -106,10 +101,7 @@ export class CommandOperatorController extends Controller {
     source.orderNo = dest.orderNo;
     dest.orderNo = temp;
 
-    await Promise.all([
+    await Promise.all([this.commandOperatorRepo.save(source), this.commandOperatorRepo.save(dest)]);
-      this.commandOperatorRepo.save(source),
-      this.commandOperatorRepo.save(dest),
-    ]);
 
     return new HttpSuccess();
   }
@@ -141,9 +133,7 @@ export class CommandOperatorController extends Controller {
     const nextOrderNo = (lastOrderNo?.orderNo ?? 1) + 1;
 
     const now = new Date();
-    const operator = Object.assign(
+    const operator = Object.assign(new CommandOperator(), {
-      new CommandOperator(),
-      {
       ...body,
       commandId: command.id,
       orderNo: nextOrderNo,
@@ -153,8 +143,7 @@ export class CommandOperatorController extends Controller {
       lastUpdateUserId: request.user.sub,
       lastUpdateFullName: request.user.name,
       lastUpdatedAt: now,
-      }
+    });
-    );
     await this.commandOperatorRepo.save(operator);
     return new HttpSuccess();
   }
@@ -166,10 +155,7 @@ export class CommandOperatorController extends Controller {
    * @param operatorId คีย์เจ้าหน้าที่ดำเนินการ
    */
   @Delete("{commandId}/{operatorId}")
-  public async deleteCommandOperator(
+  public async deleteCommandOperator(@Path() commandId: string, @Path() operatorId: string) {
-    @Path() commandId: string,
-    @Path() operatorId: string,
-  ) {
     const queryRunner = AppDataSource.createQueryRunner();
     await queryRunner.connect();
     await queryRunner.startTransaction();
@@ -215,10 +201,9 @@ export class CommandOperatorController extends Controller {
       return new HttpSuccess(true);
     } catch (error) {
       await queryRunner.rollbackTransaction();
-      throw error;
+      console.error("Delete command operator error:", error);
     } finally {
       await queryRunner.release();
     }
   }
-
 }

src/controllers/OrganizationController.ts

@@ -214,6 +214,7 @@ export class OrganizationController extends Controller {
       await sendToQueueOrgDraft(msg);
       return new HttpSuccess("Draft is being created... Processing in the background.");
     } catch (error: any) {
+      console.error("Error creating draft organization:", error);
       throw error;
     }
   }
@@ -2529,6 +2530,7 @@ export class OrganizationController extends Controller {
       await sendToQueueOrg(msg);
       return new HttpSuccess();
     } catch (error: any) {
+      console.error("Error publishing draft organization:", error);
       throw error;
     }
   }

src/services/PositionService.ts

@@ -188,6 +188,7 @@ export async function CreatePosMasterHistoryOfficer(
     return true;
   } catch (err) {
     if (manager) {
+      console.error("CreatePosMasterHistoryOfficer error (external transaction):", err);
       throw err;
     }
     console.error("CreatePosMasterHistoryOfficer transaction error:", err);