From c87b6046857d0fbfc27f89708fbce082ba619191 Mon Sep 17 00:00:00 2001
From: waruneeauy <warunee.auy@gmail.com>
Date: Tue, 26 May 2026 17:37:08 +0700
Subject: [PATCH] fixed bug api service leave type name

---
 src/controllers/ApiWebServiceController.ts | 42 +++++++++++++---------
 1 file changed, 25 insertions(+), 17 deletions(-)

diff --git a/src/controllers/ApiWebServiceController.ts b/src/controllers/ApiWebServiceController.ts
index 15eb5459..fbf0ab78 100644
--- a/src/controllers/ApiWebServiceController.ts
+++ b/src/controllers/ApiWebServiceController.ts
@@ -525,20 +525,19 @@ export class ApiWebServiceController extends Controller {
 
     // สำหรับ ProfileLeave: ตรวจสอบฟิลด์ที่ต้องการ join และแปลง propertyKey
     const profileLeaveFieldJoins: Record<string, string> = {}; // alias -> relationName
-    if (tbMain === "ProfileLeave") {
-      propertyKey = propertyKey.map((key) => {
-        const [table, field] = key.split(".");
-        if (table === "ProfileLeave") {
-          const replacement = this.PROFILELEAVE_FIELD_REPLACEMENTS[field];
-          if (replacement) {
-            const alias = `${table}_${replacement.joinRelation}`;
-            profileLeaveFieldJoins[alias] = replacement.joinRelation;
-            return `${alias}.${replacement.joinField}`;
-          }
+    // Process ProfileLeave fields regardless of main table
+    propertyKey = propertyKey.map((key) => {
+      const [table, field] = key.split(".");
+      if (table === "ProfileLeave") {
+        const replacement = this.PROFILELEAVE_FIELD_REPLACEMENTS[field];
+        if (replacement) {
+          const alias = `${table}_${replacement.joinRelation}`;
+          profileLeaveFieldJoins[alias] = replacement.joinRelation;
+          return `${alias}.${replacement.joinField}`;
         }
-        return key;
-      });
-    }
+      }
+      return key;
+    });
 
     const queryBuilder = repo.createQueryBuilder(tbMain);
 
@@ -615,10 +614,19 @@ export class ApiWebServiceController extends Controller {
     }
 
     // join สำหรับฟิลด์ ProfileLeave ที่ต้องการดึงค่าจากตารางอื่น
-    if (tbMain === "ProfileLeave" && Object.keys(profileLeaveFieldJoins).length > 0) {
-      Object.entries(profileLeaveFieldJoins).forEach(([alias, relationName]) => {
-        queryBuilder.leftJoin(`${tbMain}.${relationName}`, alias);
-      });
+    if (Object.keys(profileLeaveFieldJoins).length > 0) {
+      if (tbMain === "ProfileLeave") {
+        // ProfileLeave is the main table - direct join
+        Object.entries(profileLeaveFieldJoins).forEach(([alias, relationName]) => {
+          queryBuilder.leftJoin(`${tbMain}.${relationName}`, alias);
+        });
+      } else {
+        // ProfileLeave is a related table - the base join is already created by propertyOtherKey logic
+        // Join from the ProfileLeave alias (not from nested path)
+        Object.entries(profileLeaveFieldJoins).forEach(([alias, relationName]) => {
+          queryBuilder.leftJoin(`ProfileLeave.${relationName}`, alias);
+        });
+      }
     }
 
     // join สำหรับ PosMaster เมื่อต้องการดึงค่าจาก Profile (ข้อมูลคนครอง)