From 05f785880a3bd9a4319b2d31249e9ecf2f9760eb Mon Sep 17 00:00:00 2001 From: mamoss <> Date: Fri, 22 Aug 2025 17:37:15 +0700 Subject: [PATCH 1/3] is draft --- src/controllers/PositionController.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/controllers/PositionController.ts b/src/controllers/PositionController.ts index aeaff788..d6bf7831 100644 --- a/src/controllers/PositionController.ts +++ b/src/controllers/PositionController.ts @@ -1430,7 +1430,7 @@ export class PositionController extends Controller { }), ); - if (posMaster.orgRevision?.orgRevisionIsDraft != false) { + if (posMaster.orgRevision?.orgRevisionIsDraft == false) { const _position = posMaster.positions.find((p) => p.positionIsSelected == true); if (_position) { const current_holderId: any = posMaster.current_holderId; From 62a522d7e459254d570d9f85beca8271db53c785 Mon Sep 17 00:00:00 2001 From: mamoss <> Date: Fri, 22 Aug 2025 17:43:39 +0700 Subject: [PATCH 2/3] =?UTF-8?q?=E0=B9=80=E0=B8=9B=E0=B8=A5=E0=B8=B5?= =?UTF-8?q?=E0=B9=88=E0=B8=A2=E0=B8=99=20check?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/controllers/PositionController.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/controllers/PositionController.ts b/src/controllers/PositionController.ts index d6bf7831..2587ebd3 100644 --- a/src/controllers/PositionController.ts +++ b/src/controllers/PositionController.ts @@ -1430,7 +1430,7 @@ export class PositionController extends Controller { }), ); - if (posMaster.orgRevision?.orgRevisionIsDraft == false) { + if (posMaster.orgRevision?.orgRevisionIsCurrent == true) { const _position = posMaster.positions.find((p) => p.positionIsSelected == true); if (_position) { const current_holderId: any = posMaster.current_holderId; From 70ccf4a6c28bca9a32da9e924c4aed2be8c742a0 Mon Sep 17 00:00:00 2001 From: mamoss <> Date: Fri, 22 Aug 2025 17:53:51 +0700 Subject: [PATCH 3/3] test --- src/controllers/PositionController.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/controllers/PositionController.ts b/src/controllers/PositionController.ts index 2587ebd3..466370b6 100644 --- a/src/controllers/PositionController.ts +++ b/src/controllers/PositionController.ts @@ -1431,14 +1431,14 @@ export class PositionController extends Controller { ); if (posMaster.orgRevision?.orgRevisionIsCurrent == true) { - const _position = posMaster.positions.find((p) => p.positionIsSelected == true); + const _position = requestBody.positions.find((p) => p.positionIsSelected == true); if (_position) { const current_holderId: any = posMaster.current_holderId; const _profile = await this.profileRepository.findOne({ where: { id: current_holderId }, }); if (_profile) { - _profile.position = _position.positionName; + _profile.position = _position.posDictName ?? _null; _profile.posTypeId = _position.posTypeId; _profile.posLevelId = _position.posLevelId; await this.profileRepository.save(_profile);