hrms-bangkok/hrms-api-org
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fixed bug Redis Client Connection Leak

Browse source
This commit is contained in:
Warunee Tamkoo 2026-05-20 17:12:16 +07:00
parent d0c5d90033
commit 300f073638
2 changed files with 115 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

48
src/controllers/AuthRoleController.ts
View file

@ -123,18 +123,25 @@ export class AuthRoleController extends Controller {
// เช็คว่าถ้ามีค่า current_holderId ให้ลบ key สิทธิ์ใน redis
if (posMaster.current_holderId) {
const redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
let redisClient;
try {
redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
redisClient.del("role_" + posMaster.current_holderId, (err: Error, response: Response) => {
if (err) throw err;
});
redisClient.del("role_" + posMaster.current_holderId, (err: Error, response: Response) => {
if (err) throw err;
});
redisClient.del("menu_" + posMaster.current_holderId, (err: Error, response: Response) => {
if (err) throw err;
});
redisClient.del("menu_" + posMaster.current_holderId, (err: Error, response: Response) => {
if (err) throw err;
});
} finally {
if (redisClient) {
redisClient.quit();
}
}
}
return new HttpSuccess();
@ -266,14 +273,21 @@ export class AuthRoleController extends Controller {
...newAttrs.map((attr) => this.authRoleAttrRepo.save(attr)),
]);
const redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
let redisClient;
try {
redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
await redisClient.flushdb(function (err: any, succeeded: any) {
console.log(succeeded); // will be true if successfull
});
await redisClient.flushdb(function (err: any, succeeded: any) {
console.log(succeeded); // will be true if successfull
});
} finally {
if (redisClient) {
redisClient.quit();
}
}
return new HttpSuccess();
}

119
src/controllers/PermissionController.ts
View file

@ -37,11 +37,13 @@ export class PermissionController extends Controller {
@Get("")
public async getPermission(@Request() request: RequestWithUser) {
const redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
const getAsync = promisify(redisClient.get).bind(redisClient);
let redisClient;
try {
redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
const getAsync = promisify(redisClient.get).bind(redisClient);
let profile: any = await this.profileRepo.findOne({
select: ["id"],
@ -270,6 +272,11 @@ export class PermissionController extends Controller {
redisClient.setex("role_" + profile.id, 86400, JSON.stringify(reply));
}
return new HttpSuccess(reply);
} finally {
if (redisClient) {
redisClient.quit();
}
}
}
@Get("menu")
@ -281,11 +288,13 @@ export class PermissionController extends Controller {
orgRevisionIsCurrent: true,
},
});
const redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
const getAsync = promisify(redisClient.get).bind(redisClient);
let redisClient;
try {
redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
const getAsync = promisify(redisClient.get).bind(redisClient);
let profileType = "OFFICER";
let profile: any = await this.profileRepo.findOne({
@ -438,6 +447,11 @@ export class PermissionController extends Controller {
}
return new HttpSuccess(reply);
} finally {
if (redisClient) {
redisClient.quit();
}
}
}
/**
@ -672,11 +686,13 @@ export class PermissionController extends Controller {
@Path() system: string,
@Path() action: string,
) {
const redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
const getAsync = promisify(redisClient.get).bind(redisClient);
let redisClient;
try {
redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
const getAsync = promisify(redisClient.get).bind(redisClient);
let profileType = "OFFICER";
let profile: any = await this.profileRepo.findOne({
@ -765,6 +781,11 @@ export class PermissionController extends Controller {
}
return new HttpSuccess(reply);
} finally {
if (redisClient) {
redisClient.quit();
}
}
}
@Get("user/{system}/{action}/{id}")
@ -781,11 +802,13 @@ export class PermissionController extends Controller {
orgRevisionIsCurrent: true,
},
});
const redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
const getAsync = promisify(redisClient.get).bind(redisClient);
let redisClient;
try {
redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
const getAsync = promisify(redisClient.get).bind(redisClient);
let org = this.PermissionOrg(request, system, action);
let reply = await getAsync("user_" + id);
@ -866,14 +889,21 @@ export class PermissionController extends Controller {
}
return new HttpSuccess(reply);
} finally {
if (redisClient) {
redisClient.quit();
}
}
}
public async getPermissionFunc(@Request() request: RequestWithUser) {
const redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
const getAsync = promisify(redisClient.get).bind(redisClient);
let redisClient;
try {
redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
const getAsync = promisify(redisClient.get).bind(redisClient);
let profile: any = await this.profileRepo.findOne({
select: ["id"],
@ -1090,6 +1120,11 @@ export class PermissionController extends Controller {
redisClient.setex("role_" + profile.id, 86400, JSON.stringify(reply));
}
return reply;
} finally {
if (redisClient) {
redisClient.quit();
}
}
}
public async Permission(req: RequestWithUser, system: string, action: string) {
@ -1115,11 +1150,13 @@ export class PermissionController extends Controller {
}
public async listAuthSysOrgFunc(request: RequestWithUser, system: string, action: string) {
const redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
const getAsync = promisify(redisClient.get).bind(redisClient);
let redisClient;
try {
redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
const getAsync = promisify(redisClient.get).bind(redisClient);
let profileType = "OFFICER";
let profile: any = await this.profileRepo.findOne({
@ -1187,6 +1224,11 @@ export class PermissionController extends Controller {
redisClient.setex("posMaster_" + profile.id, 86400, JSON.stringify(reply));
}
return reply;
} finally {
if (redisClient) {
redisClient.quit();
}
}
}
// Helper method: ดึง org scope จากตำแหน่งปกติ
@ -1366,11 +1408,13 @@ export class PermissionController extends Controller {
@Get("checkOrg/{keycloakId}")
public async checkOrg(@Path() keycloakId: string) {
const redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
// const getAsync = promisify(redisClient.get).bind(redisClient);
let redisClient;
try {
redisClient = await this.redis.createClient({
host: REDIS_HOST,
port: REDIS_PORT,
});
// const getAsync = promisify(redisClient.get).bind(redisClient);
// let profileType = "OFFICER";
let profile: any = await this.profileRepo.findOne({
@ -1448,5 +1492,10 @@ export class PermissionController extends Controller {
// }
return new HttpSuccess(reply);
} finally {
if (redisClient) {
redisClient.quit();
}
}
}
}