diff --git a/src/controllers/DevelopmentEmployeeHistoryController.ts b/src/controllers/DevelopmentEmployeeHistoryController.ts index 42e34a1..82d2f9a 100644 --- a/src/controllers/DevelopmentEmployeeHistoryController.ts +++ b/src/controllers/DevelopmentEmployeeHistoryController.ts @@ -270,36 +270,12 @@ export class DevelopmentEmployeeHistoryController extends Controller { new Brackets((qb) => { qb.where( body.keyword != null && body.keyword != "" - ? "developmentHistory.prefix LIKE :keyword" + ? "CONCAT(developmentHistory.prefix, developmentHistory.firstName, ' ', developmentHistory.lastName) LIKE :keyword" : "1=1", { keyword: `%${body.keyword}%`, }, ) - .orWhere( - body.keyword != null && body.keyword != "" - ? "developmentHistory.firstName LIKE :keyword" - : "1=1", - { - keyword: `%${body.keyword}%`, - }, - ) - .orWhere( - body.keyword != null && body.keyword != "" - ? "developmentHistory.lastName LIKE :keyword" - : "1=1", - { - keyword: `%${body.keyword}%`, - }, - ) - .orWhere( - body.keyword != null && body.keyword != "" - ? "developmentHistory.position LIKE :keyword" - : "1=1", - { - keyword: `%${body.keyword}%`, - }, - ) .orWhere( body.keyword != null && body.keyword != "" ? "developmentHistory.position LIKE :keyword" @@ -350,11 +326,15 @@ export class DevelopmentEmployeeHistoryController extends Controller { const formattedData = development.map((item) => ({ id: item.id, citizenId: item.citizenId, - fullName: item.prefix + item.firstName + " " + item.lastName, + fullName: item.prefix != null && item.firstName != null && item.lastName != null + ? `${item?.prefix}${item?.firstName} ${item?.lastName}` + : "", position: item.position, year: item.development.year, posType: item.employeePosType ? item.employeePosType.posTypeName : null, - posLevel: item.employeePosLevel ? item.employeePosLevel.posLevelName : null, + posLevel: item.employeePosType && item.employeePosLevel + ? `${item.employeePosType.posTypeShortName}${item.employeePosLevel.posLevelName}` + : null, projectName: item.development.projectName, })); @@ -391,8 +371,8 @@ export class DevelopmentEmployeeHistoryController extends Controller { position: getDevelopment.position, posLevelId: getDevelopment.employeePosLevelId, posLevelName: - getDevelopment.employeePosLevel != null - ? getDevelopment.employeePosLevel.posLevelName + getDevelopment.employeePosType != null && getDevelopment.employeePosLevel != null + ? `${getDevelopment.employeePosType.posTypeShortName} ${getDevelopment.employeePosLevel.posLevelName}` : null, posTypeId: getDevelopment.employeePosTypeId, posTypeName: diff --git a/src/controllers/DevelopmentHistoryController.ts b/src/controllers/DevelopmentHistoryController.ts index 8f436a5..33f512a 100644 --- a/src/controllers/DevelopmentHistoryController.ts +++ b/src/controllers/DevelopmentHistoryController.ts @@ -265,36 +265,12 @@ export class DevelopmentOfficerHistoryController extends Controller { new Brackets((qb) => { qb.where( body.keyword != null && body.keyword != "" - ? "developmentHistory.prefix LIKE :keyword" + ? "CONCAT(developmentHistory.prefix, developmentHistory.firstName, ' ', developmentHistory.lastName) LIKE :keyword" : "1=1", { keyword: `%${body.keyword}%`, }, ) - .orWhere( - body.keyword != null && body.keyword != "" - ? "developmentHistory.firstName LIKE :keyword" - : "1=1", - { - keyword: `%${body.keyword}%`, - }, - ) - .orWhere( - body.keyword != null && body.keyword != "" - ? "developmentHistory.lastName LIKE :keyword" - : "1=1", - { - keyword: `%${body.keyword}%`, - }, - ) - .orWhere( - body.keyword != null && body.keyword != "" - ? "developmentHistory.position LIKE :keyword" - : "1=1", - { - keyword: `%${body.keyword}%`, - }, - ) .orWhere( body.keyword != null && body.keyword != "" ? "developmentHistory.position LIKE :keyword" @@ -344,7 +320,9 @@ export class DevelopmentOfficerHistoryController extends Controller { const formattedData = development.map((item) => ({ id: item.id, citizenId: item.citizenId, - fullName: item.prefix + item.firstName + " " + item.lastName, + fullName: item.prefix == null && item.firstName == null && item.lastName == null + ? "" + : `${item?.prefix}${item?.firstName} ${item?.lastName}`, position: item.position, year: item.development.year, root: item.development.root, //test