chamomind/elearning
7
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages 3 Wiki Activity Actions

refactor: simplify avatar deletion logic and improve error handling in user service.

Browse source
This commit is contained in:
JakkrapartXD 2026-01-28 15:01:48 +07:00
parent 70d2dfa4c7
commit b28dd410e2
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Backend/src/services/user.service.ts
View file

@ -207,11 +207,8 @@ export class UserService {
// Delete old avatar if exists // Delete old avatar if exists
if (user.profile?.avatar_url) { if (user.profile?.avatar_url) {
try { try {
// Extract file path from URL await deleteFile(user.profile.avatar_url);
const urlParts = user.profile.avatar_url.split('/'); logger.info(`Deleted old avatar: ${user.profile.avatar_url}`);
const oldFilePath = urlParts.slice(-2).join('/'); // Get avatars/{userId}/{filename}
await deleteFile(oldFilePath);
logger.info(`Deleted old avatar: ${oldFilePath}`);
} catch (error) { } catch (error) {
logger.warn(`Failed to delete old avatar: ${error}`); logger.warn(`Failed to delete old avatar: ${error}`);
// Continue with upload even if delete fails // Continue with upload even if delete fails
@ -221,6 +218,7 @@ export class UserService {
// Upload to MinIO // Upload to MinIO
await uploadFile(filePath, file.buffer, file.mimetype || 'image/jpeg'); await uploadFile(filePath, file.buffer, file.mimetype || 'image/jpeg');
logger.info(`Uploaded avatar: ${filePath}`);
// Update or create profile - store only file path // Update or create profile - store only file path
if (user.profile) { if (user.profile) {
await prisma.userProfile.update({ await prisma.userProfile.update({
@ -272,7 +270,7 @@ export class UserService {
return await getPresignedUrl(avatarPath, 3600); // 1 hour expiry return await getPresignedUrl(avatarPath, 3600); // 1 hour expiry
} catch (error) { } catch (error) {
logger.warn(`Failed to generate presigned URL for avatar: ${error}`); logger.warn(`Failed to generate presigned URL for avatar: ${error}`);
return ''; throw error;
} }
} }