fix(docver): drop fields value limit + treat history 404 as empty in add-in
All checks were successful
Deploy eCourt Note Web to Server / Validate Database Schema (Drizzle) (push) Successful in 5s
Deploy eCourt Note Web to Server / Build Web Docker Image (push) Successful in 1m28s
Deploy eCourt Note Web to Server / Deploy eCourt Note Web to Server (push) Successful in 4s
Deploy eCourt Note Web to Server / Notify Deployment Status (push) Successful in 0s
All checks were successful
Deploy eCourt Note Web to Server / Validate Database Schema (Drizzle) (push) Successful in 5s
Deploy eCourt Note Web to Server / Build Web Docker Image (push) Successful in 1m28s
Deploy eCourt Note Web to Server / Deploy eCourt Note Web to Server (push) Successful in 4s
Deploy eCourt Note Web to Server / Notify Deployment Status (push) Successful in 0s
Two fixes from first real-Word testing of the unmocked versioning flow: - fields value length: remove the limit entirely (was 10,000, briefly 100,000) — real court documents run 100-200 pages with content controls several hundred thousand chars long; callers are Bearer-only and the column is Postgres jsonb (up to ~255MB), so no storage bottleneck. Structural guards stay: ≤1,000 keys (was 100), key ≤200 chars, value must be string. - getVersions in versioningService now maps the history 404 to an empty list: files stamped SavedByAddIn back in the mock era enter the tracking phase before any real upload exists, so the pane shows "ยังไม่มี version ในระบบ" and Save & Version creates v1 (implicit document creation) instead of surfacing a 404 error banner. Other errors still propagate. Tests: 288/288 (new cases — 1M-char value passes, key cap 1,000/1,001, history 404 -> []). E2E against MinIO: 50k and 1M-char Thai field values upload 200 and roundtrip byte-exact through jsonb. Docs synced: PLAN-DOCVER §1, CLAUDE.md. Co-Authored-By: Claude Code <noreply@anthropic.com>
This commit is contained in:
parent
37b18c58c2
commit
b8ff622999
6 changed files with 52 additions and 13 deletions
|
|
@ -17,7 +17,7 @@
|
|||
|
||||
import * as authService from "./authService";
|
||||
import { generateGuid } from "./metadataService";
|
||||
import { apiGetJson, apiSendExpectJson } from "./apiClient";
|
||||
import { ApiError, apiGetJson, apiSendExpectJson } from "./apiClient";
|
||||
import { UploadVersionResult, VersionRecord } from "../models/versionRecord";
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
|
|
@ -81,13 +81,21 @@ export async function uploadVersion(
|
|||
}
|
||||
|
||||
/** FR-6 — version history เรียงใหม่ → เก่า (คืนสำเนากัน caller mutate store ตรง ๆ)
|
||||
* docId มาจาก fid ใน token — documentId พารามิเตอร์ไม่ถูกใช้กับ server ของจริง */
|
||||
* docId มาจาก fid ใน token — documentId พารามิเตอร์ไม่ถูกใช้กับ server ของจริง
|
||||
* 404 = เอกสารนี้ยังไม่เคยมี version (เช่น ไฟล์ที่ stamp SavedByAddIn ไว้สมัย mock แล้วเพิ่ง
|
||||
* มาใช้ backend จริง) — สำหรับ add-in ความหมายเดียวกับ list ว่าง: UI แสดง "ยังไม่มี version
|
||||
* ในระบบ" และกด Save & Version สร้าง v1 ได้เลย (upload สร้างเอกสารให้อัตโนมัติ) */
|
||||
export async function getVersions(documentId: string): Promise<VersionRecord[]> {
|
||||
if (!authService.isDemoMode()) {
|
||||
const rows = await apiGetJson<DocumentVersionDTO[]>(
|
||||
"/api/documents/versions",
|
||||
"โหลด version history ไม่สำเร็จ",
|
||||
);
|
||||
let rows: DocumentVersionDTO[];
|
||||
try {
|
||||
rows = await apiGetJson<DocumentVersionDTO[]>("/api/documents/versions", "โหลด version history ไม่สำเร็จ");
|
||||
} catch (error) {
|
||||
if (error instanceof ApiError && error.status === 404) {
|
||||
return [];
|
||||
}
|
||||
throw error;
|
||||
}
|
||||
// server เรียงใหม่ → เก่าอยู่แล้ว — แปลงเป็น VersionRecord ตามที่ UI ใช้
|
||||
return rows.map((row) => ({
|
||||
versionId: row.versionId,
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue